[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30967 [Core Tor/Tor]: Make shellcheck ignore user-created directories, and run it during pre-commit

#30967: Make shellcheck ignore user-created directories, and run it during pre-
commit
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  unspecified
 Severity:  Major                                |     Resolution:
 Keywords:  fast-fix, teor-backlog-ci,           |  Actual Points:  0.2
  042-should, tor-ci-fail-sometimes              |
Parent ID:                                       |         Points:  0.1
 Reviewer:  catalyst                             |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------
Changes (by catalyst):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:4 teor]:
 > This PR failed distcheck, I pushed a fix to the PR.
 >
 > Please check that CI passed before merging.
 Thanks! Mostly looks good. There's now a `Makefile.am` merge conflict.
 Please fix up the merge conflict and ensure that CI passes before merging.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30967#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs