[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31400 [Metrics/Onionoo]: Add Onionoo's master branch to GitLab's CI

#31400: Add Onionoo's master branch to GitLab's CI
-----------------------------+------------------------------
 Reporter:  karsten          |          Owner:  metrics-team
     Type:  enhancement      |         Status:  needs_review
 Priority:  Medium           |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:  #31398           |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------
Changes (by irl):

 * status:  new => needs_review


Comment:

 Two commits here, because a test was timing out in the GitLab CI
 environment.

 Please review:

 1.
 https://dip.torproject.org/irl/onionoo/commit/5173fe1d73c32342be937160d4974bd446c45e57
 2.
 https://dip.torproject.org/irl/onionoo/commit/4ba7b00c6f4080955af907e1dbf9dd0c79fb9a58

 My assumption is that we are testing correctness here, not speed of the
 function, maybe doubling the timeout was too much.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31400#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs