Re: [tor-bugs] #31477 [Core Tor/Tor]: Practracker integration tsts for headers and includes

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#31477: Practracker integration tsts for headers and includes
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  practracker, tech-debt,              |  Actual Points:
  refactoring, easy, 041-deferred-20190530,      |
  network-team-roadmap-july, dgoulet-merge       |
Parent ID:  #29746                               |         Points:
 Reviewer:  catalyst                             |        Sponsor:
                                                 |  Sponsor31-must
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 > Thanks! Could you please add a brief description of that bug both to
 this ticket and to the appropriate commit messages? Please force-push the
 pull request branch once you've done this.

 Good idea.  I've done that and force-pushed.

 The bug is this: I thought that saying that DependencyViolation applied to
 `*` would make it apply to all files -- but practracker doesn't support
 that.  I had to say instead that it applies to `*.h` and `*.c`.

 I force-pushed a new branch to fix the commit message.  I didn't change
 any code when I did so.

 >I'm also undecided on whether this needs a changes file. What do you
 think?

 I'm not sure whether your "this" means this branch, or this bug.  I don't
 think that the bug requires a changes file, since the bug didn't exist in
 0.4.1.  But I think that this branch needs a changes file, since it is a
 new test that wasn't there before.  Sorry I hadn't added it!  I've just
 put it in the branch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31477#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs