[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28822 [Applications/Tor Browser]: re-implement desktop onboarding for ESR 68
#28822: re-implement desktop onboarding for ESR 68
---------------------------------------------+-----------------------------
Reporter: mcs | Owner: tbb-team
Type: defect | Status: closed
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution: fixed
Keywords: ff68-esr, TorBrowserTeam201909R | Actual Points:
Parent ID: #30429 | Points: 4
Reviewer: | Sponsor:
| Sponsor44-can
---------------------------------------------+-----------------------------
Changes (by gk):
* status: needs_review => closed
* resolution: => fixed
Comment:
Thanks for the digging and the fixups. Very nice work! I cherry-picked the
Torbutton commit onto `master` (commit
d796dd27d12850bd176a85e160002755bfccfab2) and the other ones onto `tor-
browser-68.1.0esr-9.0-2` (commits
b4e8db514df16856b567be1e13cb9af11a7de6e5
535d41fd820d5b94caf43f3e403dc74b3566c837
915d521a2fae009509a229bdaeb1d3a95a17b8c1
e1ad91f3031dd08a0591d0f9d472cb49e015ad75
5d0ffb6cea1e3eca56884f087120f2b40aa2926b).
I've opened a new ticket to do The Right Thing with respect to our
onboarding that is we need a new one fitting to the new Firefox reality
instead of backing out patches and hacking around the breakage: #31660.
FWIW: I think `doCommand()` is not working anymore due to the following
change:
{{{
- oncommand="SecurityLevelButton.onCommand(this, event);"
+ onmousedown="SecurityLevelButton.onCommand();"
}}}
There is no `oncommand` handler anymore but an `onmousedown` one which
presumably fires, too, if one clicks.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28822#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs