[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31477 [Core Tor/Tor]: Practracker integration tsts for headers and includes
#31477: Practracker integration tsts for headers and includes
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: nickm
Type: defect | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: practracker, tech-debt, | Actual Points:
refactoring, easy, 041-deferred-20190530, |
network-team-roadmap-july, dgoulet-merge |
Parent ID: #29746 | Points:
Reviewer: catalyst | Sponsor:
| Sponsor31-must
-------------------------------------------------+-------------------------
Comment (by nickm):
Replying to [comment:5 catalyst]:
> Replying to [comment:4 nickm]:
> > The bug is this: I thought that saying that DependencyViolation
applied to `*` would make it apply to all files -- but practracker doesn't
support that. I had to say instead that it applies to `*.h` and `*.c`.
> I still didn't understand this description, so I looked into
`practracker.py` and `problem.py`. I'm guessing that `ProblemFilter` needs
to have its filename patterns be unambiguously denoting either `.c` or
`.h` files. It looks like `Item.get_file_type()` determines this based on
the suffix (`.c` or `.h`) of the file or pattern, defaulting to `*.c`. So
maybe a pattern of `*` would match `*.c` files but not `*.h` files? Does
this sound like an accurate description of the bug?
That's right -- the Item.get_file_type() function converts `*` to `*.c`,
so that it will match .c files, but not .h files.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31477#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs