[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31625 [Core Tor/Tor]: config refactoring: fix hierarchy of configuration variable flags
#31625: config refactoring: fix hierarchy of configuration variable flags
-----------------------------------------+---------------------------------
Reporter: nickm | Owner: nickm
Type: defect | Status: needs_review
Priority: Medium | Milestone: Tor:
| 0.4.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: network-team-roadmap-august | Actual Points: .8
Parent ID: #29211 | Points: .5
Reviewer: teor | Sponsor:
-----------------------------------------+---------------------------------
Changes (by nickm):
* status: needs_revision => needs_review
Comment:
I've tried to make the requested changes where I could. (There's one case
where I'd like to use a different ticket #31654 since there's a behavioral
change involved, and there are other cases where the code in question is
removed later in the branch.)
I think I've responded to all of your comments, but please let me know if
I missed anything. I've tested the squash operation, and the branch
squashes cleanly.
>I think the final design isn't quite what was written in the ticket, but
I still think it's ok.
Yeah, my apologies there -- the original list of flags wasn't quite right
to match Tor's current behavior, and I wanted to avoid any behavioral
changes on this branch.
>The code is mostly ok, but does need a few more comments, and maybe some
tidying up.
Do you have any tidying in mind? I didn't see any requests of this form,
but I'm happy to give it a try.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31625#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs