[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #20322 [Applications/Tor Browser]: SafeSEH support for mingw-w64 for Tor Browser on Windows
#20322: SafeSEH support for mingw-w64 for Tor Browser on Windows
-------------------------------------------------+-------------------------
Reporter: bugzilla | Owner: tbb-
| team
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-security, TorBrowserTeam201711, | Actual Points:
GeorgKoppen201711, tbb-rbm |
Parent ID: | Points:
Reviewer: | Sponsor:
| Sponsor4
-------------------------------------------------+-------------------------
Comment (by gk):
https://docs.microsoft.com/en-us/cpp/build/reference/safeseh-image-has-
safe-exception-handlers?redirectedfrom=MSDN&view=vs-2019
{{{
/SAFESEH is only valid when linking for x86 targets. /SAFESEH is not
supported for platforms that already have the exception handlers noted.
For example, on x64 and ARM, all exception handlers are noted in the
PDATA. ML64.exe has support for adding annotations that emit SEH
information (XDATA and PDATA) into the image, allowing you to unwind
through ml64 functions. See MASM for x64 (ml64.exe) for more information.
}}}
So, 64bit files `PASS` in our check script just because they are 64bit
ones. I wonder whether we need to do more here, though, given that we
don't use `ML64.exe`.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20322#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs