[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #24653 [Applications/Tor Browser]: Apply security slider improvements made on desktop back to mobile
#24653: Apply security slider improvements made on desktop back to mobile
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: enhancement | Status:
| needs_revision
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-mobile, tbb-torbutton, tbb- | Actual Points:
security-slider, tbb-parity, |
TorBrowserTeam201909 |
Parent ID: #10760 | Points: 0.25
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):
* status: needs_review => needs_revision
Comment:
Replying to [comment:16 acat]:
> Fixed in https://github.com/acatarineu/tor-browser/commit/24653+1. Isn't
`custom_summary` already the same as in torbutton?
Right, my bad. I was looking in the browser without realizing the
scrollbar. So, I thought the string was cut but it wasn't. Thanks. Now,
could you just remove the superfluous whitespace on the empty lines in
{{{
+ });
+
+ // Use the DOM parser to resolve the entity and extract its real
value
+ let header = `<?xml version="1.0"?><!DOCTYPE elem
[${locations.join("")}]>`;
+ let elem = `<elem id="elementID">&${id};</elem>`;
+ let doc = domParser.parseFromString(header + elem, "text/xml");
+ let element = doc.querySelector("elem[id='elementID']");
+
+ if (element === null) {
+ throw new Error(`Entity with id='${id}' hasn't been found`);
+ }
+
+ return element.textContent;
}}}
`git` is not happy with those. :)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24653#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs