[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #26345 [Applications/Tor Browser]: Disable tracking protection UI in FF67-esr
#26345: Disable tracking protection UI in FF67-esr
-------------------------------------------------+-------------------------
Reporter: cypherpunks | Owner: tbb-
| team
Type: defect | Status: closed
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution: fixed
Keywords: ff68-esr, tbb-9.0-must-alpha, | Actual Points:
TorBrowserTeam201909R |
Parent ID: | Points: 1
Reviewer: | Sponsor:
| Sponsor44-can
-------------------------------------------------+-------------------------
Changes (by gk):
* status: needs_review => closed
* resolution: => fixed
Comment:
Replying to [comment:9 acat]:
> Here is a patch for review: https://github.com/acatarineu/tor-
browser/commit/26345
>
> I think with the current preferences we should not be blocking anything
from the Firefox
> Enhanced Tracking Protection/Content Blocking, other than the 3rd party
cookies (which is the same as esr60).
Yes (see my last comment).
> With respect to that, Firefox moved the UI for changing cookie blocking
preference (`network.cookie.cookieBehavior`) to the new content blocking
section in `about:preferences`. If we hide that (as the patch currently
does), there is no way that users can change it via UI. I'm not sure if
that's so bad, since this would only be for advanced users that know what
they are doing, and still is possible to modify it via `about:config`.
Looking at the result of the hiding it seems this is okay. We want to
avoid users shooting themselves in the foot by clicking on some of those
options.
> We currently block all 3rd party cookies (although there is #21905 to
revise that), and this makes the "shield" icon in the siteIdentity UI
appear, so that had to be hidden too.
>
> There are some requests because of this feature going in the background
from time to time. The ones that I have checked are coming from
[https://searchfox.org/mozilla-
esr68/rev/b1a2c428a9125ade87001bb6b9e990c886dcfd31/netwerk/url-
classifier/UrlClassifierSkipListService.jsm#106
UrlClassifierSkipListService.jsm]. But I guess we can deal with that in a
separate ticket together with some other background requests that are
still happening.
Yes, please file a new ticket for that if needed. The patch looks okay to
me, especially as this is a temporary measure anyway given that we are
interested tin using tracking protection for performance improvements
later on.
Cherry-picked to `tor-browser-68.1.0esr-9.0-2` (commit
cbf4dfb66958590b64cf5b2fc63ff0ed9e2d7d0e).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26345#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs