[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31684 [Core Tor/Tor]: Add control port GETINFO support for dumping the local consensus
#31684: Add control port GETINFO support for dumping the local consensus
-------------------------------+------------------------------------
Reporter: asn | Owner: (none)
Type: task | Status: needs_review
Priority: Medium | Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: control-port easy | Actual Points:
Parent ID: | Points: 1
Reviewer: | Sponsor:
-------------------------------+------------------------------------
Comment (by ltbringer):
> This ticket creates a small reduction in code quality, because it turns
a 300-line function into a 320-line function. If you would like to improve
code quality, please add a commit that splits the two dir/status-vote/*
GETINFOs into their own static function. Otherwise, our reviewer can do
that for you, before they approve your pull request.
I will create the static function. I feel the entire function could use
some help as I see the if-else blocks having some degree of similarity (my
commit creates almost identical blocks, which differ only by a string
argument).
Also, I was unaware of the spec. I'll fix that too.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31684#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs