[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31518 [Core Tor/Tor]: HAProxy implementation in TCPProxy option.

#31518: HAProxy implementation in TCPProxy option.
--------------------------+------------------------------------
 Reporter:  haxxpop       |          Owner:  haxxpop
     Type:  enhancement   |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  proxy tcp     |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  nickm         |        Sponsor:
--------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Okay, this is looking better and better!  I think it will be ready for
 inclusion in 0.4.3.x.

 I added a suggestion to rename the "WANT_ACK" state.

 The other request I have is to see if you can write tests for more
 functions.  Right now, only around 1/4 of the new lines in your patch have
 test coverage.  Coveralls didn't add its report to the ticket for some
 reason, but you can see the coverage report at
 https://coveralls.io/builds/25644803

 If there's something you can't test, or think a test isn't necessary for,
 please let me know and we can talk about it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31518#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs