Re: [tor-bugs] #30743 [Core Tor/Tor]: Write a coccinelle script to catch increment/decrement calls inside log_debug().

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#30743: Write a coccinelle script to catch increment/decrement calls inside
log_debug().
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  enhancement   |         Status:  needs_information
 Priority:  Medium        |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  catalyst      |        Sponsor:
--------------------------+------------------------------------
Changes (by catalyst):

 * status:  needs_review => needs_information


Comment:

 Replying to [comment:3 nickm]:
 > See branch `ticket30743` with PR at
 https://github.com/torproject/tor/pull/1322 .  Running it over the source
 code with the apply.sh script in #31705 found no additional instances of
 bugs like #30628.
 Thanks! Mostly looks good. I manually verified that it detects the bug
 fixed in #30628.

 Do you think it needs a changes file? I think it would be useful it the
 changes file (and commit message) pointed at an example of a bug that this
 would catch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30743#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs