[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31303 [Applications/Tor Browser]: Browser Toolboxfails to open when tor-launcher is present
#31303: Browser Toolboxfails to open when tor-launcher is present
-------------------------------------------------+-------------------------
Reporter: pospeselr | Owner:
| pospeselr
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201909, tbb-9.0-must- | Actual Points:
alpha |
Parent ID: | Points: 1
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):
* keywords: TorBrowserTeam201909R, tbb-9.0-must-alpha =>
TorBrowserTeam201909, tbb-9.0-must-alpha
* status: needs_review => needs_revision
Comment:
Replying to [comment:8 acat]:
> I tested mcs suggestion and everything seems to work as expected in
browser toolbox (https://github.com/acatarineu/tor-launcher/commit/31303)
>
> Alternatively we could add `TOR_SKIP_LAUNCH=1` in https://searchfox.org
/mozilla-
esr68/rev/9fe22f6a90e0a5c495d22b2e8b56fac5f46b0ba0/devtools/client/framework/ToolboxProcess.jsm#258,
but I think changing tor-launcher is fine.
I agree. Just a tiny nit: please add the toolbox check after the skip
launch check so that it a) matches the order in which you declared the
constants and b) matches more likely the usage patterns of the env
variables: I'd expect both to be low but the toolbox one still much lower.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31303#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs