Re: [tor-bugs] #31589 [Core Tor/Tor]: hs-v3: Simplify decrypt_desc_layer interface

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#31589: hs-v3: Simplify decrypt_desc_layer interface
-----------------------------------------------+---------------------------
 Reporter:  asn                                |          Owner:  (none)
     Type:  defect                             |         Status:
                                               |  needs_revision
 Priority:  Medium                             |      Milestone:  Tor:
                                               |  0.4.3.x-final
Component:  Core Tor/Tor                       |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  tor-hs easy refactoring tech-debt  |  Actual Points:
Parent ID:                                     |         Points:
 Reviewer:  asn                                |        Sponsor:
-----------------------------------------------+---------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Patch looks good to me. Thanks for the code!

 Two small things:
 - Please write a changes file for your refactoring. See
 https://github.com/torproject/tor/blob/master/doc/HACKING/CodingStandards.md
 #how-we-log-changes for more details.
 - While we are at it, perhaps we can change `is_superencrypted_layer` to
 be a bool, so that we can pass `true`/`false` to the function instead of 0
 and 1?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31589#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs