[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31466 [Core Tor/Tor]: Consider demoting ".exit is disabled" log message to info

#31466: Consider demoting ".exit is disabled" log message to info
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  accepted
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  bug-bounty, hackerone, tor-          |  Actual Points:  .1
  security?, 042-should 029-backport?            |
  035-backport 040-backport 041-backport         |
  BugSmashFund                                   |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * keywords:  bug-bounty, hackerone, tor-security?, 042-should =>
     bug-bounty, hackerone, tor-security?, 042-should 029-backport?
     035-backport 040-backport 041-backport BugSmashFund
 * actualpoints:   => .1


Comment:

 See branch `bug31466_029` with PR at
 https://github.com/torproject/tor/pull/1342 .

 There's a merge conflict with 0.3.5, because of the removal of
 AllowDotExit.  See `bug31466_035` for a resolution to that conflict, with
 a PR at https://github.com/torproject/tor/pull/1343 .

 This latter branch merges cleanly to master.  To see CI running on master,
 the branch id is `bug31466_042` with a PR at
 https://github.com/torproject/tor/pull/1344 .

 I decided to go for a rate-limit here instead of demoting the log
 message's severity.  We ''do'' want people to see this message if they are
 going to attempt to use the obsolete .exit notation... we just don't want
 to spam their logs with it.

 I'll put this in needs_review once CI is happy.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31466#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs