[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31793 [Core Tor/Tor]: Bug: tor_addr_is_internal() called from src/feature/dirauth/process_descs.c:447 with a non-IP address of type 0

#31793: Bug: tor_addr_is_internal() called from
src/feature/dirauth/process_descs.c:447 with a non-IP address of type 0
-------------------------------------------+-------------------------------
 Reporter:  arma                           |          Owner:  (none)
     Type:  defect                         |         Status:  new
 Priority:  High                           |      Milestone:  Tor:
                                           |  0.4.2.x-final
Component:  Core Tor/Tor                   |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  042-regression ipv6? 042-must  |  Actual Points:
Parent ID:                                 |         Points:
 Reviewer:                                 |        Sponsor:
-------------------------------------------+-------------------------------

Comment (by teor):

 Yes, the address null and internal checks are in the wrong order:
 https://github.com/torproject/tor/pull/1267/files#diff-
 c535b81e06d7fed27d5d3cdaabf1c4b8R439
 https://github.com/torproject/tor/pull/1267/files#diff-
 c535b81e06d7fed27d5d3cdaabf1c4b8R447

 We also need to:
 * add a test that fails because of this bug
 * work out why chutney didn't fail when the authorities logged all these
 bugs

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31793#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs