[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27601 [Applications/Tor Browser]: browser notifications are not working anymore with Tor Browser 8



#27601: browser notifications are not working anymore with Tor Browser 8
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,      |  Actual Points:
  tbb-8.0.1-can, tbb-9.0-must-alpha,             |
  TorBrowserTeam201909R                          |
Parent ID:                                       |         Points:  0.5
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by acat):

 * status:  new => needs_review
 * keywords:
     tbb-8.0-issues, tbb-regression, tbb-8.0.1-can, tbb-9.0-must-alpha,
     TorBrowserTeam201909
     =>
     tbb-8.0-issues, tbb-regression, tbb-8.0.1-can, tbb-9.0-must-alpha,
     TorBrowserTeam201909R


Comment:

 Unless I'm missing some, these are the fixes we would have to backport:

 * [https://bugzilla.mozilla.org/show_bug.cgi?id=1568521 Bug 1568521 -
 Tracking protection doorhanger's Enable/Disable states don't work]
   * https://github.com/mozilla/gecko-
 dev/commit/4f11cdabb32cf1de9cd6ee871ec31f6d8cab660c

 * [https://bugzilla.mozilla.org/show_bug.cgi?id=1557729 Bug 1557729 -
 google calendar loses notification permission every time it's loaded]
   * https://github.com/mozilla/gecko-
 dev/commit/52d5f250f15152d0672a30c5c2ef9c6f67ed38ed

 * [https://bugzilla.mozilla.org/show_bug.cgi?id=1572240 Bug 1572240 -
 ContentBlockingAllowList._basePrincipalForAntiTrackingCommon is a bit
 wasteful]
   * https://github.com/mozilla/gecko-
 dev/commit/7b2ff7275b4484a9bab1d4bd4d0d4c1da513b031
   * https://github.com/mozilla/gecko-
 dev/commit/e06a6e7ca6873165785927fd3c6e29a0d3e5aac2
   * https://github.com/mozilla/gecko-
 dev/commit/575c480fc556dc5614a9291dd8fb37928d21a316
   * https://github.com/mozilla/gecko-
 dev/commit/68aa0ff3f4c1e2048ef078714ad57b3ad5a75191
   * https://github.com/mozilla/gecko-
 dev/commit/05feeeb79be579eb1c651aba060ed783e12470d3
   * https://github.com/mozilla/gecko-
 dev/commit/c771ae8334e2f691decbcc95526b64e521c11339

 The first two are simple fixes, but the third one is not so easy to
 backport. As it was mentioned on IRC, the patch writer thinks this is
 risky to backport
 (https://bugzilla.mozilla.org/show_bug.cgi?id=1560623#c9). I took a quick
 look, and the patch as is relies on this other patch
 https://bugzilla.mozilla.org/show_bug.cgi?id=1510569 to update
 `aContentBlockingAllowListPrincipal`: https://searchfox.org/mozilla-
 central/rev/7531325c8660cfa61bf71725f83501028178cbb9/dom/interfaces/base/nsIBrowser.idl#160.
 I assume it should not be difficult to adapt it to use the old JSM code
 that is still present in esr68, but probably not a straightforward
 backport either.

 So, given that we are hiding/disabling content blocking for now (and in
 principle are not affected by that regression) should we postpone
 backporting this patch until we explore/decide enabling content blocking?
 If yes, perhaps we could update #30939 so that we remember to backport
 this.

 The first two are backported here: https://github.com/acatarineu/tor-
 browser/commits/27601.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27601#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs