[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #19859 [Core Tor/Tor]: Expose stream isolation information to controllers
#19859: Expose stream isolation information to controllers
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: (none)
Type: enhancement | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs tor-control dns isolation | Actual Points:
needs-spec needs-design term-project |
Parent ID: | Points: 3
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by JeremyRand):
> That's right; the spec patch should document the new behavior in
control-spec.txt.
Okay, I'll work on that next. I should have a spec patch for you within a
few days.
> It would also be really good to have tests for the new code here.
This patch is mostly a copy/paste job of the existing code for the `CIRC`
event. So ordinarily I'd base the tests for this patch on the `CIRC`
tests as well, but a brief look at the tests didn't find any tests for
that `CIRC` code. Am I correct in thinking that the `CIRC` stream
isolation fields don't have any tests right now, or did I miss something?
If that's correct, I'm still okay with writing tests if you want, but
given that this is my first time hacking on the core Tor code, it's likely
that I'll ask for some minor hand-holding on IRC, as the test codebase
used by core Tor is not something that I have any familiarity with.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19859#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs