[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

#25483: Windows reproducible build of snowflake
--------------------------------------------+------------------------------
 Reporter:  arlolra                         |          Owner:  cohosh
     Type:  project                         |         Status:
                                            |  needs_revision
 Priority:  High                            |      Milestone:
Component:  Circumvention/Snowflake         |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  anti-censorship-roadmap-august  |  Actual Points:
Parent ID:  #19001                          |         Points:
 Reviewer:                                  |        Sponsor:
                                            |  Sponsor28-must
--------------------------------------------+------------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  TorBrowserTeam201909R, anti-censorship-roadmap-august => anti-
     censorship-roadmap-august


Comment:

 Okay, I looked over the changes. Overall, they are good, thanks! I get
 everything built and it's reproducible on all platforms on different
 machines. Nice work!

 I have one small thing an one request:

 Please squash the commits into fewer ones. I think it's reasonable to have
 essentially three commits: one for adding all the new
 dependencies/projects, one for making sure the snowflake projects gets
 adapted and it's available on Windows as well and finally one where all
 the old WebRTC related projects/code/documentation etc. gets removed.

 In commit 40d3220d300bd7c394b152becec73fbb77c3f6dd you have
 {{{
 -[% IF c("var/linux") || c("var/osx") -%]
 +[% IF c("var/linux") || c("var/osx") || c("var/windows") -%]
 }}}
 You can remove the whole IF-clause as Android is not using `build` but has
 its own script (`build.android` in `projects/tor-browser`).

 Regarding providing snowflake on Android, we probably need a different
 approach anyway, so #31293 is not so much an issue for that. We'll likely
 pick the work up in #28672 and #30318 again after we are good here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25483#comment:67>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs