Re: [tor-bugs] #31794 [Circumvention/Snowflake]: Errors swallowed

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#31794: Errors swallowed
-------------------------------------+------------------------
 Reporter:  sah                      |          Owner:  (none)
     Type:  defect                   |         Status:  new
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:                           |        Sponsor:
-------------------------------------+------------------------

Comment (by cohosh):

 Replying to [comment:3 sah]:
 > Thanks for replying cohosh.
 >
 > I wasn't sure if changing the flow of the application should happen (in
 that, currently errors are being ignored, so dying now would change the
 behaviour), so I sent all errors generated to log. I tried to keep the
 error messages as unique as possible, with the idea that they're going to
 be more for debugging than user, if they become noisy it'll become clearer
 what errors are being generated, where, and how they should be dealt with?
 Cool, I'll take a look in a review.
 >
 > How do I send a PR so that the changes can be seen, with a view to
 deciding on if I've taken the correct approach?
 There are two options:
 - You can run git format-patch and upload the patch(es) as attachments to
 this ticket.
 - And easier way is to comment with a link to a branch of a cloned
 snowflake repository that has your changes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31794#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs