Re: [tor-bugs] #25483 [Circumvention/Snowflake]: Windows reproducible build of snowflake

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#25483: Windows reproducible build of snowflake
--------------------------------------------+------------------------------
 Reporter:  arlolra                         |          Owner:  cohosh
     Type:  project                         |         Status:
                                            |  needs_revision
 Priority:  High                            |      Milestone:
Component:  Circumvention/Snowflake         |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  anti-censorship-roadmap-august  |  Actual Points:
Parent ID:  #19001                          |         Points:
 Reviewer:                                  |        Sponsor:
                                            |  Sponsor28-must
--------------------------------------------+------------------------------
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 Okay, thanks. Let's look a bit closer now:

 commit 00ac64fb26121858a8e8fa0a6332508f0ae9fbdf

 The change in the `goxnet` project is
 {{{
 -git_hash: ed066c81e75eba56dd9bd2139ade88125b855585
 +git_hash: da137c7871d7
 }}}
 Could we get here the full hash here again? (Same goes for `goxsys`)

 Could you change the commit message so it shows what you are actually
 doing? Right now it is quite confusing and not really matching what is
 happening in the commit.

 commit 3ce20d5c5e013fb6e60492eb7fa601e36ca20098

 I think
 {{{
 -targets:
 -  linux-i686:
 -    var:
 -      arch_deps:
 -        - pkg-config
 -        - libx11-dev:i386
 -  linux-x86_64:
 -    var:
 -      arch_deps:
 -        - pkg-config
 -        - libx11-dev
 -  osx-x86_64:
 -    var:
 -      arch_deps:
 -        - pkg-config
 -        - faketime
 }}}
 should already be in that commit, no? I mean that target clean-up is not
 needed just because you are removing the old WebRTC related projects but
 because you are switching snowflake over to `pion`.

 Please look over the commit message here again. There are redundancies in
 it.

 commit 3b96850779b25174429d15f2c301df6a2517ebd4

 see comment for previous comment "arch_deps no longer required for
 snowflake." needs to get moved to the previous commit's commit message,
 too, if you want to keep it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25483#comment:69>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs