[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31614 [Core Tor/Tor]: Implement clean_up_backtrace_handler()

#31614: Implement clean_up_backtrace_handler()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.5.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:  0.4
  consider-backport-if-needed, diagnostics,      |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression,         |
  BugSmashFund                                   |
Parent ID:                                       |         Points:  0.2
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:15 nickm]:
 > This mostly LGTM.  Before merging, let's think make a conscious decision
 about what we should do about restart testing (see discussion on #31735).

 (I think you meant #31736 - the quick fix mutex ticket.)

 I think we should leave restart testing for #31735 - the eventual fix
 mutex ticket. I'm out of time on this issue, and the changes are smaller
 than I expected.

 > Also, I worry that this could interfere with our sandbox code: I think
 that in order to allow us to call sigaction() on all of these values, we
 might need to add them to sb_rt_sigaction() in sandbox.c.

 Yes, the sandbox would also need to use these values after a re-
 initialise.

 I made the following changes:
 * added the signals to the sandbox
 * rewrote one of the commits based on #31736
 * rebased on the latest maint-0.3.5 to fix a test-stem error

 Here is the PR:
 * 0.3.5: https://github.com/torproject/tor/pull/1302

 The merge forward is clean.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31614#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs