[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31372 [Core Tor/Tor]: Appveyor and Travis should use "make -k"

#31372: Appveyor and Travis should use "make -k"
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-ci, 029-backport, 035-backport,  |  Actual Points:  .1
  040-backport, 041-backport, 042-should         |
Parent ID:                                       |         Points:
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 I like `make -k || make -k` and I'm happy with the ugliness, because
 almost no-one will see it.
 (And we can explain it in a comment, and perhaps with `echo "Re-running
 make to show errors"`.)

 But I am also happy to change my process, and do a search.

 What do you think would be easier for us, and for new contributors?
 I'll let you decide?


 It's probably also worth mentioning that this change will slow down
 failures. I think that's ok, but I sent an email to the network team list
 with other ways to speed up CI.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31372#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs