[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31334 [Core Tor/Tor]: Use SEVERITY_MASK_IDX() to find the LOG_ERR index in the unit tests

#31334: Use SEVERITY_MASK_IDX() to find the LOG_ERR index in the unit tests
-------------------------------+------------------------------------
 Reporter:  teor               |          Owner:  teor
     Type:  defect             |         Status:  merge_ready
 Priority:  Medium             |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor       |        Version:  Tor: 0.2.5.2-alpha
 Severity:  Normal             |     Resolution:
 Keywords:  042-can asn-merge  |  Actual Points:  0.1
Parent ID:                     |         Points:  0.1
 Reviewer:  nickm              |        Sponsor:
-------------------------------+------------------------------------
Changes (by nickm):

 * keywords:  042-can => 042-can asn-merge
 * status:  needs_review => merge_ready


Comment:

 LGTM. I say "no backport" since this is a readability issue.

 I also noticed that we are still using ~0 here, when the type has become
 64 bits. I opened #31854 for that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31334#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs