Re: [tor-bugs] #30429 [Applications/Tor Browser]: Rebase Tor Browser patches for Firefox ESR 68

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#30429: Rebase Tor Browser patches for Firefox ESR 68
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff68-esr, tbb-9.0-must-alpha,        |  Actual Points:
  TorBrowserTeam201909                           |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor44-can
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:75 gk]:
 > Replying to [comment:74 acat]:
 > > Fixed in https://github.com/acatarineu/tor-browser/commits/30429+11. I
 also changed the last check for the `.onion` case to `if ((mState &
 STATE_IS_SECURE) == 0) {`, because I think the previous `if (mState !=
 STATE_IS_INSECURE) {` may have erased some flags in case of a https onion.
 > >
 > > I changed the comment, but not completely sure if you meant that or
 something else :)
 >
 > I meant something else but I was wrong. However, the changed comment
 *does* add value, so thanks. The patch looks good to me. I'd like to have
 another reviewer here (as this is a C++ patch), likely pospeselr.
 Menawhile, though, just a small nit to fix up:
 > {{{
 > +    // router over tor (.onion).
 > }}}
 > s/router/routed/

 Additionally, it seems that somehow your patch is breaking the mobile
 experience. With the latest nightly I can see an onion icon and the
 session is marked as secure. However, testing your patch with my
 `30429_test` (https://gitweb.torproject.org/user/gk/tor-
 browser.git/log/?h=30429_test) just gives the regular globe and an
 insecure connection setting.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30429#comment:77>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs