Re: [tor-bugs] #31759 [Core Tor/Tor]: Make "annotate_ifdef_directives" script comply with line-width limits

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#31759: Make "annotate_ifdef_directives" script comply with line-width limits
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  042-should    |  Actual Points:  .1
Parent ID:  #31713        |         Points:
 Reviewer:  catalyst      |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------

Comment (by nickm):

 I've updated the branch and PR at
 ​https://github.com/torproject/tor/pull/1339 .

 There are now tests, in the form that python's doctest module.  I've
 opened a new ticket #31869 to run them automatically.  To try them
 yourself, run "python -m doctest
 ./scripts/maint/annotate_ifdef_directives.py"

 I've tried to document the 79/80 character issue and the newline handling
 more carefully.

 I've added some code to produce balanced parentheses.

 Predictably, adding tests found a bug in the negation-processing code: I
 had exchanged two characters in a regular expression.  I added a fixup!
 commit to handle that.

 I'll put this back in needs_review once CI has passed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31759#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs