[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31652 [Core Tor/Tor]: hs-v3: Service circuit retry limit should not close a valid circuit
#31652: hs-v3: Service circuit retry limit should not close a valid circuit
---------------------------------------------+-----------------------------
Reporter: dgoulet | Owner: neel
Type: defect | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-hs, tor-circuit, 042-should | Actual Points:
Parent ID: #30200 | Points: 0.1
Reviewer: asn | Sponsor:
| Sponsor27-must
---------------------------------------------+-----------------------------
Changes (by neel):
* status: needs_revision => needs_review
Comment:
I fixed the issue while allowing tests to pass.
However, I believe my code is tested with the test routine
`test_service_event()`:
{{{
/* Now, we'll create an IP with a registered circuit. The IP object
* shouldn't go away. */
ip = helper_create_service_ip();
service_intro_point_add(service->desc_current->intro_points.map, ip);
ed25519_pubkey_copy(&circ->hs_ident->intro_auth_pk,
&ip->auth_key_kp.pubkey);
hs_circuitmap_register_intro_circ_v3_service_side(
circ, &ip->auth_key_kp.pubkey);
run_housekeeping_event(now);
tt_int_op(digest256map_size(service->desc_current->intro_points.map),
OP_EQ, 1);
/* We'll mangle the IP object to expire. */
ip->time_to_expire = now;
run_housekeeping_event(now);
tt_int_op(digest256map_size(service->desc_current->intro_points.map),
OP_EQ, 0);
}}}
Setting as needs review.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31652#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs