[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #30344 [Core Tor/Tor]: conn_read_callback is called on connections that are marked for closed
#30344: conn_read_callback is called on connections that are marked for closed
-------------------------------------------------+-------------------------
Reporter: robgjansen | Owner: asn
Type: defect | Status:
| needs_information
Priority: Medium | Milestone: Tor:
| 0.4.2.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.3.5.8
Severity: Normal | Resolution:
Keywords: tor-conn, 035-backport, | Actual Points:
041-deferred-20190530, 042-should |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by asn):
* cc: pastly (removed)
* status: assigned => needs_information
Comment:
Hello Rob, I took your patch from the top comment and slimmed it down a
bit to https://github.com/torproject/tor/pull/1380
I removed the parts about the writing/flushing because I did not
understand exactly what they were doing, and also because the patch from
comment:1 did not seem to need them. What are we missing by not doing it?
Also I did not do the approach from comment:1 because we don't want to add
stuff to `connection_mark_for_close()` (Also see the documentation change
I did to this effect).
Let me know how you like this, and if it works for you please!
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30344#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs