[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: Proposal: Download consensus documents only when it will be trusted



On Wed, Apr 23, 2008 at 03:40:17PM +0200, Peter Palfrader wrote:
> On Tue, 22 Apr 2008, Peter Palfrader wrote:
> 
> > > Here's a first go at the server side.
> > Split into its own function.
> 
> .) Not all authorities on consensus->voters actually signed the consensus.
> .) decode the requested fingerprint rather than encoding each
>    authority's id digest.  This gets rid of one of the two smartlists
>    and a bunch of small mallocs.
>

Looks good now.  I say check it in.  Two thing, though.

First thing: could you also patch dir-spec.txt to document the new
URL, and document which versions of Tor started accepting it?

Second thing:

> + * Clients can say they only want a consensus if it's signed by more
> + * than half the authorities in <list>.  They pass this list in

Tags in doxygen comments need to be valid HTML.  House style is to
write <b>list</b>.

peace,
-- 
Nick