> On 24 Dec 2017, at 11:14, Damian Johnson <atagar@xxxxxxxxxxxxxx> wrote: > >> Do you want me to add an explicit end of record comment, or is the >> comma sufficient? > > Hi Tim. I'd rather not rely on just a comma. I can easily see us > tweaking the layout so 'expect a line with only a comma' breaks. > > I actually like both of the other suggested options: having > 'extrainfo=0' so that's explicit *and* a delimiter. For instance... > > /* ============================== */ > > ... or whatever. That would both help with parsing and make the file > nicer to read. Done! * the file now starts with a type and a version line: /* type=fallback */ /* version=2.0.0 */ * extrainfo is mandatory (occasionally we won't get a descriptor, so we'll warn and mark the relay extrainfo=0) * each fallback entry ends with /* ===== */ Two remaining questions: * is 6 extra info caches (up from 4) enough in a list of 150? * do you want the delimiter before the first fallback entry as well? Sample entry: "5.9.110.236:9030 orport=9001 id=0756B7CD4DFC8182BE23143FAC0642F515182CEB" " ipv6=[2a01:4f8:162:51e2::2]:9001" /* nickname=rueckgrat */ /* extrainfo=1 */ /* ===== */ , Sample file: https://trac.torproject.org/projects/tor/attachment/ticket/22759/fallback_dirs_new_format_version.inc T -- Tim Wilson-Brown (teor) teor2345 at gmail dot com PGP C855 6CED 5D90 A0C5 29F6 4D43 450C BA7F 968F 094B ricochet:ekmygaiu4rzgsk6n xmpp: teor at torproject dot org ------------------------------------------------------------------------
Attachment:
signature.asc
Description: Message signed with OpenPGP
_______________________________________________ tor-dev mailing list tor-dev@xxxxxxxxxxxxxxxxxxxx https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev