Re: [tor-dev] test_cmdline_args.py on Windows

[Damian Johnson <atagar@xxxxxxxxxxxxxx>]

Nice catch Gisle!

This is actually the first I've heard about test_cmdline_args.py.
Interesting. These would be a good fit for our stem.process integ
tests...

  https://gitweb.torproject.org/stem.git/tree/test/integ/process.py

I'd be up for adding them, then tor could use them to exercise itself.
But that said I've been trying to persuade Nick to use Stem's tests
for years, so maybe not worthwhile.


On Mon, Jan 5, 2015 at 7:52 AM, Gisle Vanem <gvanem@xxxxxxxx> wrote:
> There are some problems with 'run_tor()' and line-endings.
> It doesn't forsee any '\r\n' from 'Popen()' and since 'lines()'
> only splits on '\n', most of the tests fails.
>
> With this little patch:
>
> @@ -64,7 +64,7 @@
>          yield fp[i:i+4]
>
>  def lines(s):
> -    out = s.split("\n")
> +    out = s.splitlines()
>
> I only get 2 errors in that script. The others like:
>   self.assertTrue(out_verif.endswith("Configuration was valid\n"))
>
> needs another patch which is beyond my Python knowledge.
>
> --
> --gv
> _______________________________________________
> tor-dev mailing list
> tor-dev@xxxxxxxxxxxxxxxxxxxx
> https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev
_______________________________________________
tor-dev mailing list
tor-dev@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev