[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-dev] <unistd.h> in buffers_net.c



Hi,

Thanks for this bug report and patch.

> On 3 Jan 2019, at 13:27, Gisle Vanem <gisle.vanem@xxxxxxxxx> wrote:
> 
> Some recent change has added a:
>  #include <unistd.h>
> 
> which fails for MSVC (it doesn't have it).
> 
> Since I fail to find any way to comment on Trac or Gitweb,
> I give notice here. Patching into:
> 
> --- a/src/lib/net/buffers_net.c 2019-01-02 18:57:42
> +++ b/src/lib/net/buffers_net.c 2019-01-03 03:16:32
> @@ -21,7 +21,10 @@
> #endif
> 
> #include <stdlib.h>
> +
> +#ifndef _MSC_VER
> #include <unistd.h>
> +#endif
> 
> #ifdef PARANOIA
> 
> ----------------
> 
> works fine.

We used a slightly different check in:
https://github.com/torproject/tor/commit/4e4f93d364e33bb46e271f3b960a2cf5f38f402e

T

Attachment: signature.asc
Description: Message signed with OpenPGP

_______________________________________________
tor-dev mailing list
tor-dev@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev