On Fri, Jun 23, 2017 at 10:29:32AM -0400, Zack Weinberg wrote: > On Fri, Jun 23, 2017 at 9:29 AM, Nick Mathewson <nickm@xxxxxxxxxxxx> wrote: > > On Thu, Jun 22, 2017 at 10:49 PM, <f55jwk4f@xxxxxxxxxxx> wrote: > >> I noticed tor sometimes exits 0 on error > >> [...] > >> When to exit 0 on error? > > > > When the error is unrecoverable, and continuing would be worse then exiting. > > I don't think the question was "when is it appropriate to _exit_ on > error?" I think it was "when is it appropriate to exit _0_ (i.e. > apparently successfully) on error?" > > My expectation would be that exit(0) on fatal error is presumptively a > minor bug, it should be exit(1), and if there is some compelling > reason to exit successfully in a particular error case, there ought to > be a comment explaining that reason. > > zw Yes. I mean why to exit success instead of failure. But I don't know if those cases are typos, because there are 2 such cases, and a typo like that can be easily spotted in a review.
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ tor-dev mailing list tor-dev@xxxxxxxxxxxxxxxxxxxx https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev