Re: [or-cvs] r10422: Fix patch r10411; fix from robert hogan. (in tor/trunk: . src/or)

[Roger Dingledine <arma@xxxxxxx>]

On Thu, May 31, 2007 at 02:48:31PM -0400, nickm@xxxxxxxx wrote:
>  Fix patch r10411; fix from robert hogan.
> 
> Property changes on: tor/trunk
> ___________________________________________________________________
>  svk:merge ticket from /tor/trunk [r13103] on 8246c3cf-6607-4228-993b-4d95d33730f1
> 
> Modified: tor/trunk/src/or/config.c
> ===================================================================
> --- tor/trunk/src/or/config.c	2007-05-31 18:48:28 UTC (rev 10421)
> +++ tor/trunk/src/or/config.c	2007-05-31 18:48:31 UTC (rev 10422)
> @@ -2326,7 +2326,7 @@
>  {
>    int r;
>    char buf[1024];
> -  if (*value == ROUTER_MAX_DECLARED_BANDWIDTH) {
> +  if (*value > ROUTER_MAX_DECLARED_BANDWIDTH) {
>      /* This handles an understandable special case where somebody says "2gb"
>       * whereas our actual maximum is 2gb-1 (INT_MAX) */
>      --*value;

Don't we need to fix the --*value part too, or most values will
end up causing value to exceed our intended cap?

--Roger