[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: Fix for #937 - support dynamic crypto acceleration engines

To: or-dev@xxxxxxxxxxxxx
Subject: Re: Fix for #937 - support dynamic crypto acceleration engines
From: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date: Sun, 31 May 2009 13:38:27 -0400
Delivered-to: archiver@xxxxxxxx
Delivered-to: or-dev-outgoing@xxxxxxxx
Delivered-to: or-dev@xxxxxxxx
Delivery-date: Sun, 31 May 2009 13:38:28 -0400
In-reply-to: <4ef5fec60905301529w40d49a2fsf4fb5f08cd988eb0@xxxxxxxxxxxxxx>
Mail-followup-to: Nick Mathewson <nickm@xxxxxxxxxxxxxx>, or-dev@xxxxxxxxxxxxx
References: <4ef5fec60905301529w40d49a2fsf4fb5f08cd988eb0@xxxxxxxxxxxxxx>
Reply-to: or-dev@xxxxxxxxxxxxx
Sender: owner-or-dev@xxxxxxxxxxxxx
User-agent: Mutt/1.5.13 (2006-08-11)

On Sat, May 30, 2009 at 03:29:17PM -0700, coderman wrote:

Hi!  This looks pretty good.  Just one thing:

   +  if ((old->HardwareAccel != new_val->HardwareAccel)
   +      || (old->AccelName != new_val->AccelName)
   +      || (old->AccelDir != new_val->AccelDir)) {

In C you can't compare strings with == and !=; you need to use
strcmp().

I've added a patch to fix this up, added a changelog entry, and merged
the patch.

-- 
Nick

References:
- Fix for #937 - support dynamic crypto acceleration engines
  - From: coderman

Prev by Author: Re: Proposal 165: Easy migration for voting authority sets
Next by Author: Re: Proposal 165: Easy migration for voting authority sets
Previous by thread: Re: Fix for #937 - support dynamic crypto acceleration engines
Index(es):
- Author
- Thread