[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-dev] Whonix's help_check_tor_bootstrap.py



Damian Johnson:
>> That script is stable, no bug reports in a while, stem is working fine. :)
> 
> Great!
> 
>> That authentication line and "password" is only in there to make stem
>> happy.
> 
> Stem should be perfectly fine without providing a password (that's an
> optional argument). If your proxy handles the authentication then why
> have that authenticate() call at all?
> 
> I would definitely suggest the progress parsing change, otherwise tor
> upgrades might accidentally break you. Minor mistake on my part
> though...
> 
>   match = re.match('.* PROGRESS=([0-9]+).*', line)
> 
> ... should be...
> 
>   match = re.match('.* PROGRESS=([0-9]+).*', bootstrap_status)
> 
> Cheers! -Damian

Your suggestions have been implemented:
https://github.com/Whonix/Whonix/commit/af46b55166fddac959c00d55557c1dd2a2408e0f

Thank you again, Damian! Much appreciated!

Cheers,
Patrick

_______________________________________________
tor-dev mailing list
tor-dev@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev