[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [or-cvs] [tor/master 4/6] Remove "is this too slow?" XXXX comments for code not appearing in profiles
- To: or-dev@xxxxxxxxxxxxx
- Subject: Re: [or-cvs] [tor/master 4/6] Remove "is this too slow?" XXXX comments for code not appearing in profiles
- From: Robert Ransom <rransom.8774@xxxxxxxxx>
- Date: Fri, 29 Oct 2010 02:33:15 -0700
- Delivered-to: archiver@xxxxxxxx
- Delivered-to: or-dev-outgoing@xxxxxxxx
- Delivered-to: or-dev@xxxxxxxx
- Delivery-date: Fri, 29 Oct 2010 05:30:44 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:subject :message-id:in-reply-to:references:x-mailer:mime-version :content-type; bh=GhCwkJjI7AGVF1EISZccdB3+q+3kVhuZyJxNxUfY9Cg=; b=QeH1u/zl6lMr9zq7icKKLqR9VgSKJZjB6RG6g5lKf/cbtevdTE4rTOdo0+cHjTEVKq FMa6eCjl+78kX8xMaMftq1sYPmohfVj3SHUY2d0bzGmSM0d6gMvoU5J0IAy0R5suPmc/ e/2ykgT46aMN1EckgV0Yip07FAjF9gxnUoBbw=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; b=Nkc03VmA2kJizd7Q8F9Pkmj7+7QXFvzMXk/OxeytgED6SrtObKiv9SWYoE3k77aDRr COIqmQwhW6rGQMe//tA+83rKHoszI2wOOy8+JvaG03zaxe0QOzFvz4NNoDrUuNn4R0Wp oP5y8NfdREo/jAVMvCIVliHl7+bUhq5Rhgh3Y=
- In-reply-to: <20101015160733.86CC15E156@xxxxxxxxxxxxxxxxxxxxx>
- References: <20101015160733.86CC15E156@xxxxxxxxxxxxxxxxxxxxx>
- Reply-to: or-dev@xxxxxxxxxxxxx
- Sender: owner-or-dev@xxxxxxxxxxxxx
On Fri, 15 Oct 2010 16:07:33 +0000 (UTC)
nickm@xxxxxxxxxxxxxx wrote:
> Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
> Date: Fri, 15 Oct 2010 11:21:33 -0400
> Subject: Remove "is this too slow?" XXXX comments for code not appearing in profiles
> Commit: 247ce5876a56cdbbd6a7b3f501476ff10f4bce5e
>
> ---
> src/or/circuitbuild.c | 2 --
> src/or/networkstatus.c | 3 +--
> src/or/policies.c | 2 +-
> src/or/routerlist.c | 7 -------
> 4 files changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c
> index a4cdf81..9c7262a 100644
> --- a/src/or/circuitbuild.c
> +++ b/src/or/circuitbuild.c
> @@ -3032,8 +3032,6 @@ choose_good_entry_server(uint8_t purpose, cpath_build_state_t *state)
> nodelist_add_node_family(excluded, node);
> }
> if (firewall_is_fascist_or()) {
> - /*XXXX This could slow things down a lot; use a smarter implementation */
> - /* exclude all ORs that listen on the wrong port, if anybody notices. */
The second comment line here should not have been removed.
> smartlist_t *nodes = nodelist_get_list();
> SMARTLIST_FOREACH(nodes, const node_t *,node, {
> if (!fascist_firewall_allows_node(node))
Robert Ransom
Attachment:
signature.asc
Description: PGP signature