Re: [tor-dev] HSv3 descriptor work in stem

[George Kadianakis <desnacked@xxxxxxxxxx>]

George Kadianakis <desnacked@xxxxxxxxxx> writes:

> Damian Johnson <atagar@xxxxxxxxxxxxxx> writes:
>
>> Thanks George! Yup, work on that branch is in progress:
>>
>> https://gitweb.torproject.org/user/atagar/stem.git/log/?h=hsv3
>
> Hello Damian,
>
> thanks for the reply here! I'm now back and ready to start working again
> on onionbalance/stem.
>
> What is your plan with the hsv3 branch? Should I start reviewing your
> changes already, or give you more time to do more?
>
> Thanks a lot for all the work! :)

Hello again,

I took a super quick look (particularly at the easy parts of your
changes). Thanks for all the changes!

My only feedback so far is that the python2 port commits have broken
python3 for me (particularly the ed25519 blinding implementation). In
general, the ed25519 blinding implementation is very hairy Python3
crypto code and it won't be easy to support both versions I think.

Would it be egregious to provide hsv3 support only for python3 users so
that we can use python3 features as we wish?

I personally plan to use HSv3 support for onionbalance and that will be
in python3, so I wouldn't mind that at all. Not sure who else is gonna
use hsv3 support in the near future.

Cheers!

PS: From now on perhaps we can use #31823 for code related discussions
    (sorry for the medium mixing)
_______________________________________________
tor-dev mailing list
tor-dev@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev