Iâm not sure itâs necessary to prevent the controller setting this option. We trust the controller, and might need it to be able to set this option for compatibility with ephemeral hidden services. What is the threat model where a controller could set this option, but not do things that are much worse?
I donât think 512 bytes is enough for the current implementation, I recommend at least 2048 bytes. (See below.)
I would appreciate a list of the data needed by the current version of the hidden service protocol to rendezvous, even if we donât want to specify the exact format, or specify data items for future implementations. This helps ensure that the limits in the proposal are sane, and that the proposal doesnât have any unexpected implementation issues. From reading rend_service_receive_introduction think the data is at least: * service_id - the hidden service address (16 base32 bytes) * intro_key - the introduction-point specific key (128 binary bytes, 171 base64 bytes) * request - the encrypted portion of the INTRODUCE2 cell (up to 476 binary bytes(?), 635 base64 bytes) Therefore, I think the minimum for the current hidden service implementation is around 830 bytes, at least if we want to offload the maximum processing to the rendezvous instances by sending the entire encrypted INTRODUCE2 cell. Therefore, Iâd suggest that a limit of 2048 bytes is much more reasonable for future-proofing this proposal. It also looks like you might need to split rend_service_t into: * introduction point-specific data * rendezvous-specific data * shared data Does any data need to be shared, and, if so, how do you intend to keep the shared data synchronised? (Putting it in the RendezvousData each time might blow out the size considerably.) Iâd also appreciate an example of which parts of rend_service_receive_introduction could be performed by each of the cooperating tor instances. I assume that sending the data âas early as possibleâ would offload the most processing to the rendezvous side. I think that the split could happen right before the decryption of the cell, at the lines: stage_descr = "decryption"; /* Now try to decrypt it */ This would avoid having to share the intro point encrypted replay cache (intro_point->accepted_intro_rsa_parts), but thereâs still the hidden service Diffie-Hellman handshake cache (service->accepted_intro_dh_parts). If we donât share that: * two backend instances could accidentally compete for the same rendezvous point if the client times out * a client could more easily DoS the hidden service by using the same Diffie-Hellman handshake Weâd have to decide if this security issue outweighs the benefit of doing the decryption on multiple rendezvous-side instances. In general, Iâm concerned that we need to think through the implementation of this proposal more carefully, because it will help us decide whether itâs compatible with: * Current Hidden Services * Next-Generation Hidden Services And perhaps make changes to any of these proposals to make them work together. Iâd also note that itâs definitely not compatible with Single Onion Services as specified in Proposal #252, as there is no rendezvous in that protocol. Tim Tim Wilson-Brown (teor) teor2345 at gmail dot com PGP 968F094B teor at blah dot im OTR CAD08081 9755866D 89E2A06F E3558B7F B5A9D14F |
Attachment:
signature.asc
Description: Message signed with OpenPGP using GPGMail
_______________________________________________ tor-dev mailing list tor-dev@xxxxxxxxxxxxxxxxxxxx https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev