[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-dev] [Patch] common/util_bug.h



> On 13 Sep 2016, at 18:52, Gisle Vanem <gvanem@xxxxxxxx> wrote:
> 
> The 'IF_BUG_ONCE__' for non-gcc is wrong. A simple patch:
> 
> --- a/util_bug.h 2016-09-13 10:44:59
> +++ b/util_bug.h 2016-09-08 20:24:45
> @@ -117,7 +117,7 @@
> #else
> #define IF_BUG_ONCE__(cond,var)                                         \
>   static int var = 0;                                                   \
> -  if (PREDICT_UNLIKELY(cond)) ?                                         \
> +  if (PREDICT_UNLIKELY(cond) ?                                          \
>       (var ? 1 :                                                        \
>        (var=1,                                                          \
>         tor_bug_occurred_(SHORT_FILE__, __LINE__, __func__,             \
> --
> --gv

Thanks for reporting this.
Logged as https://trac.torproject.org/projects/tor/ticket/20141

Tim

Tim Wilson-Brown (teor)

teor2345 at gmail dot com
PGP C855 6CED 5D90 A0C5 29F6 4D43 450C BA7F 968F 094B
ricochet:ekmygaiu4rzgsk6n
xmpp: teor at torproject dot org






Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail

_______________________________________________
tor-dev mailing list
tor-dev@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev