Re: [tor-relays] task-6329 / tor relays stats patch

[Karsten Loesing <karsten@xxxxxxxxxxxxxx>]

Hi Michael,

I'm cc'ing tor-relays for the discussion here, because I figured if
you're okay with sharing the patch, you're probably also okay with a
public discussion of it. :)

On 7/21/12 4:19 PM, Michael Zeltner wrote:
> Hi Karsten,
> 
> On my way out, and I would otherwise forget but here you go, maybe you'd like
> this.
> 
> Best from Metalab/Vienna,
> Michael

Thanks for sending the patch!  Most of it looks good, but I took out the
--family-for-fp option which, I think, isn't entirely correct.  This
option looks for relays having the given fingerprint in their family
line, but it doesn't cross-check if the given relay has those relays in
its family line, too.  The option also doesn't look at nicknames (of
relays with the Named flag) in family lines, which means it might miss
some family members.  Oh, and it would be really cool to have a -F or
--by-family option to aggregate by families.  I wonder if we should do
the whole family-calculating business inside Onionoo and add a
family_number field which has the same number for relays in the same
family.  The script could then look up the family number of the given
relay and display all relays with that family number.  Would that make
sense?  Want to extend the script once Onionoo has such a field?

Thanks!
Karsten

_______________________________________________
tor-relays mailing list
tor-relays@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-relays