Re: [tor-relays] Testers needed for Nyx beta release

[Damian Johnson <atagar@xxxxxxxxxxxxxx>]

Thanks Andrew! Great points, changes pushed.


On Mon, Oct 30, 2017 at 3:32 PM, Andrew Deason <adeason@xxxxxxxx> wrote:
> On Mon, 30 Oct 2017 14:00:44 -0700
> Damian Johnson <atagar@xxxxxxxxxxxxxx> wrote:
>
>> Hi all. Pushed a couple changes to address feedback thus far...
>
> Sorry if this is not the right place for nitpicking/bikeshedding, but:
>
>> * Fixed the os.putenv() issue that came up for FreeBSD...
>>
>>   https://gitweb.torproject.org/nyx.git/commit/?id=bcb0122
>
> Bare 'except:' clauses are really not recommended for error handling,
> since it catches things like SystemExit and GeneratorExit (not to
> mention it also triggers if you misspell 'putenv' or something). You can
> use 'except Exception:' instead, but here I would suggest at least
> 'except OSError:'.
>
>> * When sqlite3 is unavailable encouraging folks to contact us so we
>>   can provide per-platform advice. For FreeBSD providing the 'pkg
>>   install' command mentioned earlier...
>>
>>   https://gitweb.torproject.org/nyx.git/commit/?id=4bfe05d
>
> s/Unfortunatley/Unfortunately/
>
> And thanks for your work; don't mistake this for me being ungrateful :)
>
> --
> Andrew Deason
> adeason@xxxxxxxx
>
> _______________________________________________
> tor-relays mailing list
> tor-relays@xxxxxxxxxxxxxxxxxxxx
> https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-relays
_______________________________________________
tor-relays mailing list
tor-relays@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-relays