[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: Grrr...SafeLogging doesn't work in 0.2.1.12-alpha :-{
- To: or-talk@xxxxxxxxxxxxx
- Subject: Re: Grrr...SafeLogging doesn't work in 0.2.1.12-alpha :-{
- From: Christopher Davis <loafier@xxxxxxxxx>
- Date: Tue, 10 Feb 2009 11:26:20 -0800
- Delivered-to: archiver@xxxxxxxx
- Delivered-to: or-talk-outgoing@xxxxxxxx
- Delivered-to: or-talk@xxxxxxxx
- Delivery-date: Tue, 10 Feb 2009 14:26:31 -0500
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=ycpkvhElJvY4V5Geh8X2yeEqr+YqpHDIFcAtoG06vRQ=; b=ie2/+dpvsIw5t8PJYbeyeV6g3BR/k2HWqNUUwb7VbFRWdUJxTNAtdMAGS1r4rzVbXC Mwu1JNNyFvU6Xu6nf21DMQNPDOWuLq0is7F4t08IVH4327hE3ceILLucVQuPbpwecaea U4C7Y88k8fY8U/VkWop5s8aIoN0i6L41uyues=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=CiBmONqTcwRfECXl6KlHI7T6wnXdLeT0vfAnlwX54RHbvDrw1e79fZUjdk06xWmoKx ejBQKIIxBRueGgrrZYfn9xSKVJmb6Q4v5qIMFvrWvbhesN6MVuy0lAkoy2xbj72m0xzD 5zemqs1T3UWwOmGrwiDFLvSIZRhqZJmXziSl8=
- In-reply-to: <200902101833.n1AIXo58027891@xxxxxxxxxxxxx>
- References: <200902101833.n1AIXo58027891@xxxxxxxxxxxxx>
- Reply-to: or-talk@xxxxxxxxxxxxx
- Sender: owner-or-talk@xxxxxxxxxxxxx
- User-agent: Mutt/1.4.2.3i
On Tue, Feb 10, 2009 at 12:33:50PM -0600, Scott Bennett wrote:
> On Tue, 10 Feb 2009 12:22:57 -0600 (CST) I wrote:
> > I think we need a quick patch for this one. I just built and fired up
> >0.2.1.12-alpha with no changes to torrc from what I had already. As soon
> >as exit requests came in, I saw (at INFO-level logging) that IP addresses are
> >now being logged as the exit connections are made, whereas in 0.2.1.7-alpha
> >and earlier, the port numbers appeared, but the IP addresses had been scrubbed.
> >I tried adding "SafeLogging 1" to torrc in case the default had somehow gotten
> >changed, but that seemed to have no effect either.
>
> Here's more information. The "[scrubbed]" field still appears in the
> messages, but the IP addresses now appear inside parentheses right after
> the port number used. For example,
>
> Feb 10 11:43:05.346 [info] connection_edge_finished_connecting(): Exit connection to [scrubbed]:43 (81.91.170.6) established.
>
> Unless what looks scary is somehow actually innocuous, I do think we
> need a patch ASAP.
This looks like the offending message:
--- src/or/connection_edge.c.orig 2009-02-10 11:20:48.000000000 -0800
+++ src/or/connection_edge.c 2009-02-10 11:21:05.000000000 -0800
@@ -328,9 +328,9 @@
conn = TO_CONN(edge_conn);
tor_assert(conn->state == EXIT_CONN_STATE_CONNECTING);
- log_info(LD_EXIT,"Exit connection to %s:%u (%s) established.",
- escaped_safe_str(conn->address),conn->port,
- fmt_addr(&conn->addr));
+ log_info(LD_EXIT,"Exit connection to %s:%u established.",
+ escaped_safe_str(conn->address),conn->port);
+
conn->state = EXIT_CONN_STATE_OPEN;
connection_watch_events(conn, EV_READ); /* stop writing, continue reading */
--
Christopher Davis