[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[vidalia-svn] r3605: Missed a "!" in checking the return value of QFile::rename() (vidalia/trunk/src/vidalia/network)



Author: edmanm
Date: 2009-03-09 22:11:04 -0400 (Mon, 09 Mar 2009)
New Revision: 3605

Modified:
   vidalia/trunk/src/vidalia/network/geoipcache.cpp
Log:

Missed a "!" in checking the return value of QFile::rename(). Caught by
coderman. We didn't actually use the return value right now so it doesn't
affect operation, but yay for clarity and correctness.


Modified: vidalia/trunk/src/vidalia/network/geoipcache.cpp
===================================================================
--- vidalia/trunk/src/vidalia/network/geoipcache.cpp	2009-03-09 16:14:19 UTC (rev 3604)
+++ vidalia/trunk/src/vidalia/network/geoipcache.cpp	2009-03-10 02:11:04 UTC (rev 3605)
@@ -74,7 +74,7 @@
     }
   }
   /* Rename the temporary file into place. */
-  if (tmpCacheFile.rename(cacheFile.fileName())) {
+  if (!tmpCacheFile.rename(cacheFile.fileName())) {
     return err(errmsg, tmpCacheFile.errorString());
   }
   return true;