[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [f-cpu] HDL coding rules
On Tue, Jul 30, 2002 at 01:43:42PM +0200, Just an Illusion wrote:
> Please, Etienne forgive me, but your code can be a good example to
> illustrated this subject.
>
> In the eu_inc.vhd file :
>
> * some keywords are in capital letter, some others not.
> * The generic parameter eu_inc_width can be put in capital letter, to
> help distinction with signal and variable value.
> * The interface signals aren't globally in capital letter except for
> function abs_chunk.
>
> That doesn't change the result, but can help the code reading.
>
> The next remark is not a "coding rule", but more a "coding style" rule.
>
> I thing is better if you create a package which embedded all the
> necessary component (and perhaps functions) needed for your eu_inc and
> eu_cmp rather than "use work.find_lsb;" notation.
I'm totally agree with you. For the moment, my code works, it's the more
important :-) . But, it should better if we can easy read the code. Discuss around code
will be more easy.
*************************************************************
To unsubscribe, send an e-mail to majordomo@seul.org with
unsubscribe f-cpu in the body. http://f-cpu.seul.org/