[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [gftp] Codepage related problems.
- To: gftp-users@xxxxxxxx
- Subject: Re: [gftp] Codepage related problems.
- From: "Brian Masney" <masneyb@xxxxxxxx>
- Date: Fri, 23 Mar 2007 21:48:29 -0400
- Delivered-to: archiver@seul.org
- Delivered-to: gftp-users-outgoing@seul.org
- Delivered-to: gftp-users@seul.org
- Delivery-date: Fri, 23 Mar 2007 21:48:44 -0400
- Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:references:x-google-sender-auth; b=B3yVqIViveHpIlFXCLZeOxrZ2Cw+oz13DtUleNxhR52Xdg6Y8WvNMwKkAa7qE4NE1OnwH3txI3abhS/eNnizXjT33qjxEO2URtSs8iOCAEdTtXLquxAhQkLsbezOgp+od7ai7DbS/cOmxYk5oFEyeisyP6EpvgzCIndTozj24lc=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:references:x-google-sender-auth; b=j5fhGMJ4HFK+U7RP6Lz3sW3aorjfjdwNZNj/e/frun6udcR665HaYLLidLlVUYJU/DRUHisfQCyOnmPJ5GtgIyuQ/kzij05bpak2UTUUrYfA7yB9FYxWgMSP21+uLgSBCSyIZtDH2k/fwbHMuyKCslXnORffndMxk6pmD30U/Pg=
- In-reply-to: <20070323002045.1587fad3.alxorlov@pochta.ru>
- References: <20070323002045.1587fad3.alxorlov@pochta.ru>
- Reply-to: gftp-users@xxxxxxxx
- Sender: owner-gftp-users@xxxxxxxx
Hi Alexander,
Thanks for the patches. I commited them to CVS.
Brian
On 3/22/07, Alexander Orlov <
alxorlov@xxxxxxxxx> wrote:Hello, everybody!
New post-2.0.18 gFTP is perfect! Almost all codepages related problems are gone.
But some are still exist.
First of all there is a little error in lib/protocols.c
When I set "remote_charsets=CP1251" in configuration,
function _gftp_get_next_charset returns just "CP125".
The solution should be:
--- lib/protocols.c (revision 904)
+++ lib/protocols.c (working copy)
@@ -427,7 +427,7 @@
else
len = endpos - *curpos + 1;
- for (retlen = len - 1;
+ for (retlen = len;
(*curpos)[retlen - 1] == ' ' || (*curpos)[retlen - 1] == '\t';
retlen--);
The second problem. For example, I open some remote FTP server with codepage
CP1251. gFTP tries to convert name "anonymous" from UTF-8 to CP1251, and
initializes request->iconv. But then it tries to use the same request->iconv
to convert remote filenames back from CP1251 to UTF-8, and it fails.
So, I think, that there should be two iconv's: request->iconv_to and
request->iconv_from.
Atached file gftp.patch-2 is a solution for this problem (it works perfectly
for me). It is selfexplainable, I think.
Thank you, for a such good program!
P.S. Sorry, for my poor english.
--
Alexander Orlov