[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [Libevent-users] Re: [PATCH] http: on connection reset, detach the closed fd from the bufferevent



On Tue, Feb 19, 2013 at 11:35 AM, Catalin Patulea <catalinp@xxxxxxxxxx> wrote:
> [-cc: my personal email, added by mistake]
>
> Ping. We've been seeing good results with this.

Could you be more specific about the good results, and how to
reproduce them?  Or how to reproduce/observe the undesired behavior?
It would also be good to have an explanation of how the patch is
supposed to work.

It can be tricky to analyze evhttp changes, and so I'd really like to
have more to work on than the original bug description. ("I've been
seeing fds getting reused and bufferevents adding/removing events on
the underlying evmap when they shouldn't be touching that fd
anymore.")

Of course, the very best fix would be a unit test that fails without
this patch, but succeeds with it.

many thanks,
--
Nick
***********************************************************************
To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
unsubscribe libevent-users    in the body.