[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16467 [Tor]: Faster Ed25519 implementation.

#16467: Faster Ed25519 implementation.
-----------------------------+------------------------------------
     Reporter:  yawning      |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor          |    Version:  Tor: 0.2.7
   Resolution:               |   Keywords:  performance, tor-relay
Actual Points:               |  Parent ID:  #9663
       Points:               |
-----------------------------+------------------------------------

Comment (by teor):

 I believe that clang static analyzer complains about garbage values
 because it doesn't know the length of the char * buffers passed in to
 `ed25519_donna_keygen` and `ed25519_donna_sign`.

 As far as I can tell, clang assumes that char *'s are NUL-terminated
 strings, and expects to see a `strlen` or similar call. So it gets
 confused when the byte buffers are walked in 4-byte chunks, up to 64
 bytes. (And I'm not sure it's a simple matter to convince clang how that
 the buffers are 64 bytes, nor do I feel it's a particularly productive
 activity.)

 Yawning, would you mind if we added a comment to those two functions about
 the spurious errors?
 It would save the effort of someone tracking them down again.
 But I really don't mind either way.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16467#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs