[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16467 [Tor]: Faster Ed25519 implementation.

#16467: Faster Ed25519 implementation.
-----------------------------+------------------------------------
     Reporter:  yawning      |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor          |    Version:  Tor: 0.2.7
   Resolution:               |   Keywords:  performance, tor-relay
Actual Points:               |  Parent ID:  #9663
       Points:               |
-----------------------------+------------------------------------

Comment (by yawning):

 Replying to [comment:16 teor]:
 > Yawning, would you mind if we added a comment to those two functions
 about the spurious errors?
 > It would save the effort of someone tracking them down again.
 > But I really don't mind either way.

 I don't mind at this point since I split off the tor version of the
 ed25519 code into it's own file when I did the squash/rebase, mostly for
 my sanity (In general I want to try to minimize changes to the code that's
 still common with upstream, but this stuff is mostly tor specific).
 There's a giant comment describing what our external interface does, is
 that where something like this should be, or should the comment(s) live
 inside each function?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16467#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs