[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[tor-bugs] #1564 [Tor-Tor server]: Reported dirreq-v3-stats are 0.00%
#1564: Reported dirreq-v3-stats are 0.00%
----------------------------+-----------------------------------------------
Reporter: karsten | Owner: karsten
Type: defect | Status: new
Priority: normal | Milestone: Calculate directory request shares
Component: Tor-Tor server | Version:
Keywords: | Parent:
----------------------------+-----------------------------------------------
Since late May 2010, the dirreq-v3-stats that directory mirrors report are
very low or even 0.00%. Mike has identified the cause for this bug:
> For the love of Chaos, router_get_my_share_of_directory_requests() is
> the dirtiest hack I've seen in a while, no wonder it broke :)
>
> Your problem is that the global variables you rely on are not set by
> smartlist_choose_by_bandwidth_weights(), which is the new
> implementation of the weighted selection algorithm. They are only set
> by smartlist_choose_by_bandwidth(). You could update
> smartlist_choose_by_bandwidth_weights() to set those variables, but
> man, there's got to be a better way :)
We should investigate new approaches to calculate directory request shares
from the descriptor archives instead of believing in what directories tell
us. Afterwards, we can decide whether to fix dirreq-v3-stats in Tor, or to
take them out entirely.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1564>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online